andygrove opened a new issue, #162:
URL: https://github.com/apache/datafusion-spark/issues/162

   > [!NOTE]
   > An LLM (Claude Code) created this issue. It compared the native 
expressions in Apache DataFusion Comet (`native/spark-expr`) with the functions 
in this crate. Check the details before you rely on them.
   
   ### Is your feature request related to a problem or challenge?
   
   Comet has a native, Spark-compatible implementation of `max_by` and `min_by` 
that datafusion-spark does not have.
   
   Spark expressions: `max_by`, `min_by`
   
   Comet source (at `3878424d9`):
   - 
[`agg_funcs/max_min_by.rs`](https://github.com/apache/datafusion-comet/blob/3878424d90c23de3c6355a53b293c22822876944/native/spark-expr/src/agg_funcs/max_min_by.rs)
   
   ### Describe the solution you'd like
   
   Port the implementation and its tests from Comet into datafusion-spark, and 
add `.slt` cases under `crates/sqllogictest`. Comet can then use the 
datafusion-spark version and remove its copy.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to