galaxytemple commented on PR #117:
URL: https://github.com/apache/datafusion-spark/pull/117#issuecomment-6901822794
I agree with the findings and have updated the PR accordingly.
- Updated `#[user_doc]` description and `sql_example` in `atan2.rs` to
reflect the Spark-compatible `-0.0` behavior and expected output
(`3.141592653589793`).
- Refined the code comment in `spark_atan2` to make it clear that Spark adds
`0.0` before calling `Math.atan2`.
- Added a test case with `(-0.0::double, -1.0::double)` in `atan2.slt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]