ewoodbury commented on code in PR #2848:
URL:
https://github.com/apache/datafusion-ballista/pull/2848#discussion_r4582244323
##########
ballista/scheduler/src/planner.rs:
##########
@@ -202,6 +202,35 @@ impl DefaultDistributedPlanner {
stages.append(&mut child_stages);
}
+ // A nested-loop join tracks which build rows matched in memory shared
by
+ // its probe partitions, so a join type that emits build rows is only
+ // correct in one task. Give its probe side a one-partition stage of
its
+ // own: an inline `CoalescePartitionsExec` would not hold, as
+ // `EnsureRequirements` removes one the join does not require.
+ if let Some(join) = execution_plan.downcast_ref::<NestedLoopJoinExec>()
+ && !collect_left_broadcast_safe(*join.join_type())
Review Comment:
Added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]