AdamGS opened a new pull request, #27473:
URL: https://github.com/apache/datafusion/pull/27473

   ## Which issue does this PR close?
   
   - Closes #10244.
   
   ## Rationale for this change
   
   Ran into this issue while working on #27380, and the motivating case here is 
aliases like `count(1) AS "count(*)`, which is even mentioned in the call site 
in `datafusion/sql/src/select.rs`. I've also found the already existing issue 
mentioned above.
   
   ## What changes are included in this PR?
   
   Instead of keeping aliases as they are, we also rename them to the left 
side's schema field name. 
   
   ## What is the testing strategy for this PR?
   
   Added dedicated SLT cases, which I've also verified against DuckDB.
   
   ## Are there any user-facing changes?
   
   Should only enable new cases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to