mbutrovich commented on PR #323: URL: https://github.com/apache/datafusion-spark/pull/323#issuecomment-6921833071
How do we want DataFusion updates to arrive? Minor and patch updates of `datafusion*` aren't ignored here, but line 32 excludes them from `all-other-cargo-deps` and no other group covers them. So Dependabot opens a separate PR for each of our 11 `datafusion*` crates ([docs](https://github.com/github/docs/blob/bde6409ff9f0c9810db391f0590d2256e956209d/content/code-security/reference/supply-chain-security/dependabot-options-reference.md?plain=1#L324-L326)). That happens on each 56.x release, and on each weekly run while `main` follows `branch-56` and the branch has moved. datafusion-iceberg has the same config and got separate PRs for its DataFusion crates on the same day (apache/datafusion-iceberg#77, apache/datafusion-iceberg#78, apache/datafusion-iceberg#79). If we want Dependabot to propose DataFusion updates, a group puts them in one PR. Leaving out `update-types` lets the group also take the `branch-56` commit bumps, which aren't semver versions. The ignore rule above still keeps majors out. ```yaml datafusion: applies-to: version-updates patterns: - "datafusion*" ``` If we'd rather update DataFusion by hand, as Comet does in practice, we could drop `update-types` from this ignore entry so Dependabot skips `datafusion*` entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
