comphead commented on PR #318:
URL: https://github.com/apache/datafusion-spark/pull/318#issuecomment-6923711801

   Follow-up suggestions now that this and the other CI PRs (#320, #321) are on 
`main`:
   
   1. **Cache eviction.** Each Rust job saves its own `Swatinem/rust-cache` 
entry (0.8 to 1.8 GB), and PR runs save one too. The repository is at 12.98 GB 
across 11 caches right now, above the 10 GB default, and PR entries 
(`refs/pull/*/merge`) have already evicted the `main` caches for clippy, test 
and rustdoc. So most runs start cold. Saving only from `main`, as 
apache/datafusion does, keeps the useful entries:
   
      ```yaml
      - uses: Swatinem/rust-cache@v2
        with:
          save-if: ${{ github.ref == 'refs/heads/main' }}
      ```
   
      This applies to every `rust-cache` step (`lint.yml`, `test.yml`, 
`docs.yml`, `sqllogictest.yml`).
   
   2. **Cancel superseded runs.** None of the workflows set `concurrency`, so a 
force-push leaves the earlier runs of all seven workflows going. Today's runs 
on `main` took about 30 minutes, mostly in the queue. For example:
   
      ```yaml
      concurrency:
        group: ${{ github.workflow }}-${{ github.head_ref || github.sha }}
        cancel-in-progress: true
      ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to