viirya commented on code in PR #27428:
URL: https://github.com/apache/datafusion/pull/27428#discussion_r4590886611


##########
datafusion/ffi/src/physical_expr/mod.rs:
##########
@@ -395,6 +399,15 @@ unsafe extern "C" fn hash_fn_wrapper(expr: 
&FFI_PhysicalExpr) -> u64 {
     hasher.finish()
 }
 
+unsafe extern "C" fn eq_fn_wrapper(

Review Comment:
   The marker check is what keeps this from reading another library's 
`private_data`, but no test reaches the `false` branch. 
`ffi_physical_expr_hash` only exercises the same-library path, because 
`ForeignPhysicalExpr` stores `ffi_expr.clone()` and `clone_fn_wrapper` resets 
the marker. Could a test compare expressions from two images loaded with 
`get_module_copy` and assert they're unequal?



##########
docs/source/library-user-guide/upgrading/57.0.0.md:
##########
@@ -97,3 +97,21 @@ that aligns with the SQL specification.
 ```txt
 COPY (SELECT * FROM t ORDER BY c1) TO 'ordered.parquet';
 ```
+
+### `FFI_ExecutionPlan` carries input requirements

Review Comment:
   Since this is going into 56.0.0, should this section move to `56.0.0.md` 
here too, so main and `branch-56` agree?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to