shahwazreza commented on code in PR #27118: URL: https://github.com/apache/datafusion/pull/27118#discussion_r4593387127
########## datafusion/sqllogictest/test_files/dynamic_filter_pushdown_config.slt: ########## @@ -1163,3 +1163,93 @@ SET datafusion.execution.target_partitions = 4; statement ok RESET datafusion.execution.parquet.pushdown_filters; + +# Regression for https://github.com/apache/datafusion/issues/26029. +# When the TopK filter is pushed into a scan, each sort key is rewritten in +# terms of the file's columns. One row per row group lets TopK tighten its +# filter before the answer rows, which are last in each file, are read. +statement ok +SET datafusion.execution.target_partitions = 1; + +statement ok +SET datafusion.execution.parquet.pushdown_filters = true; + +statement ok +SET datafusion.explain.physical_plan_only = true; + +query I +COPY (SELECT value AS b FROM generate_series(0, 19)) Review Comment: Thanks for pointing this out, the issue did mention the UInt64 error and I somehow missed covering it. Added in 411678e, and it fails without the fix, so that case is tested now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
