NoahKusaba commented on PR #2852: URL: https://github.com/apache/datafusion-ballista/pull/2852#issuecomment-6939044519
Thanks for the review. TPC-DS SF1 (`tpcgen-cli`), standalone, 16 partitions, `prefer_hash_join=false` as in CI, main vs this branch: - **Static planner:** all 99 distributed plans match main's. - **Adaptive planner, `max_partitions_per_task = 1`:** all 19 union queries match DataFusion and none fails. One stage runs as one task: q49's three ranked branches, 3 partitions. Main also gets all 19 right, since q49's `UNION` drops the duplicates; the bug needs a `UNION ALL` with a merging branch, as in `split_union.rs`. - **`run-tpcds`:** I can't add labels here, could you? It runs only the static planner, whose plans don't change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
