goldmedal commented on code in PR #12525:
URL: https://github.com/apache/datafusion/pull/12525#discussion_r1765355913
##########
datafusion/sqllogictest/test_files/string/init_data.slt.part:
##########
@@ -15,10 +15,12 @@
# specific language governing permissions and limitations
# under the License.
-# --------------------------------------
-# Test `substr()` with literal arguments
-# --------------------------------------
-include ./substr_literal.slt.part
+statement ok
+create table test_source as values
+ ('Andrew', 'X', 'datafusion📊🔥', '🔥'),
+ ('Xiangpeng', 'Xiangpeng', 'datafusion数据融合', 'datafusion数据融合'),
+ ('Raphael', 'R', 'datafusionДатаФусион', 'аФус'),
+ (NULL, 'R', NULL, '🔥');
Review Comment:
Because we started to implement some ASCII-faster paths, I think we should
always consider testing both ASCII-only and Unicode cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
