Omkar-Wagholikar commented on PR #27544: URL: https://github.com/apache/datafusion/pull/27544#issuecomment-7000829002
Hi @kumarUjjawal, Thanks for the further comments, really good points! I've pushed a commit to resolve two of them: - the Any and All arms now share one CASE builder in rewrite_set_comparison.rs The quantifier only picks the filter (IsTrue or IsFalse) and the THEN/ELSE values. - build_join_with_count_bug now takes the HAVING expression by value, and its only caller moves it in. Removing the extra clone. For the other two: - The as usize truncation in is fairly older than this PR. To keep this PR to its title, I would prefer to fix it and other similar instances that I can find separately under a new issue. - For exists_subquery, I left it as it is. I'm pretty sure moving the subquery into the last call would need two versions of the function, or at least an extra clone on the first call, for the saving of one shallow node clone. Happy to change it if you'd prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
