Omkar-Wagholikar commented on code in PR #27544:
URL: https://github.com/apache/datafusion/pull/27544#discussion_r4624797827
##########
datafusion/optimizer/src/rewrite_set_comparison.rs:
##########
@@ -105,26 +105,28 @@ fn build_set_comparison_subquery(
Box::new(right_expr),
));
- let true_exists =
- exists_subquery(&subquery,
Expr::IsTrue(Box::new(comparison.clone())))?;
let null_exists =
exists_subquery(&subquery,
Expr::IsNull(Box::new(comparison.clone())))?;
let result_expr = match quantifier {
Review Comment:
updated, Any and All arms now share one CASE builder in
rewrite_set_comparison.rs The quantifier only picks the filter (IsTrue or
IsFalse) and the THEN/ELSE values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]