cool9850311 commented on PR #27395:
URL: https://github.com/apache/datafusion/pull/27395#issuecomment-7006278996
> Thanks, we are getting better here.
>
> Now that we have broken the symptoms into two separate tickets, can you
pleaes break this PR into two separate / more focused PRs
>
> One for the fix / feature #27494 and the other for the new pushdown feature
>
> The goal is to make it as easy for you and us to review this PR as possible
@alamb
The two issues are one bug seen twice. Both plans come out node-for-node
identical:
```text
-- #27494 SELECT file_row_index() AS r FROM small OFFSET 1 LIMIT 2
ProjectionExec: expr=[file_row_index() as r]
GlobalLimitExec: skip=1, fetch=2
DataSourceExec: file_groups={1 group: [[small.parquet]]}, limit=3
-- #27495 SELECT s['a'] AS v FROM t OFFSET 5 LIMIT 3
ProjectionExec: expr=[get_field(s@0, a) as v]
GlobalLimitExec: skip=5, fetch=3
DataSourceExec: file_groups={1 group: [[st.parquet]]}, projection=[s],
limit=8
```
The leaf projection is planted on the `TableScan`, physical planning inserts
a `GlobalLimitExec` between them for the pushed-down skip, and no projection
can move below that node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]