andygrove opened a new pull request, #377:
URL: https://github.com/apache/datafusion-spark/pull/377

   ## Which issue does this PR close?
   
   Part of #376.
   
   ## Rationale for this change
   
   `main` fails CI since #301 and #316 landed together. `conditional/nanvl.slt` 
fails in the new evaluate mode, and the PySpark runner reports a difference at 
line 53.
   
   ## What changes are included in this PR?
   
   - The seven records that need `nanvl`'s `simplify` rewrite (a lazy expr2 
under ANSI mode, and string arguments) are marked `skipif evaluate`, linking 
#376.
   - Line 53 used `-0.0::double`, which Spark types as a DECIMAL literal with 
no negative zero, so Spark returned `false`. It now uses `'-0.0'::double`, as 
`log1p.slt` does.
   
   ## Are these changes tested?
   
   `nanvl.slt` passes in both modes, and the PySpark runner reports no 
differences for it.
   
   ## Are there any user-facing changes?
   
   No.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to