andygrove commented on PR #4818: URL: https://github.com/apache/datafusion-comet/pull/4818#issuecomment-7017283952
Thank you @mbutrovich, @rich7420, @sunchao and @comphead for the detailed reviews. The divisor underflow, the captured ANSI mode, the empty-partial merge and the fixture coverage all came from your comments. I'm closing this PR because it isn't the highest priority right now, and because `kurtosis` and `skewness` would be better implemented once in `datafusion-spark`, where both can share one central-moment accumulator and other engines can use it. I've added what the prototype showed and what review found to apache/datafusion-spark#179, which already tracks `kurtosis` (`skewness` is #180). When that lands, Comet can wire it in with a serde as it does for other `datafusion-spark` functions. The prototype branch is `feat/kurtosis-native-support` on my fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
