mbutrovich commented on PR #26593: URL: https://github.com/apache/datafusion/pull/26593#issuecomment-7020111854
> 1. Leave this as is, defer to the operator to handle bounds. If an operator declares `Partitioning::Range` with bounds and its input doesn't have bounds, the operator should handle this. Option 1 works for me. It matches how sources declare partitioning and sortedness today, and the joins already take bounds only from the side whose rows they emit. I left a suggestion on the struct docs so authors of custom operators see the rule. > I have reverted the previous change were we strip the bounds. At b25c830, [`RangePartitioning::adapt`](https://github.com/apache/datafusion/blob/b25c830c48aba597a778772c2447503885f98565/datafusion/physical-expr/src/partitioning.rs#L551-L557) still sets both bounds to `None`, and I'd keep it that way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
