zuccamia commented on issue #17498: URL: https://github.com/apache/datafusion/issues/17498#issuecomment-7023099980
I'd like to take `datafusion.format.date_format` as my first contribution. Since #26045, a bad format no longer panics, but `SET` still accepts it (e.g. `'%H'`), and then every query printed as a table fails, even a plain `SELECT 'ok'`, until the option is reset. Following #24545 / #25788, I have a branch that adds a validated type, which runs the #26045 check for `date_format` at `SET` time, plus`set_variable.slt` tests. This changes the public field type, so I'll also flag it as an API change in the PR. The other four temporal formats (`datetime_format`, `timestamp_format`, `timestamp_tz_format`, `time_format`) could follow the same way in separate PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
