milenkovicm commented on code in PR #2899:
URL: 
https://github.com/apache/datafusion-ballista/pull/2899#discussion_r4636256206


##########
ballista/scheduler/src/scheduler_server/mod.rs:
##########
@@ -98,7 +98,7 @@ pub trait JobIdGenerator: Sync + Send {
 /// A monotonically increasing sortable snowflake job id generator
 /// which does not capture machine id as part result.
 pub(crate) struct DefaultJobGenerator {
-    generator: AtomicSnowflakeGenerator<SnowflakeMastodonId, MonotonicClock>,
+    generator: AtomicSnowflakeGenerator<SnowflakeMastodonId, CachedClock>,

Review Comment:
   `CachedClock` or `DirectClock` 🤔 starting a thread or reading time on every 
call? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to