alexanderbianchi opened a new pull request, #123:
URL: https://github.com/apache/datafusion-iceberg/pull/123

   Closes #118.
   
   Resolve the scan's snapshot during `FileScanTaskProviderBuilder::build()` 
and retain the resulting iceberg-rust `TableScan`. Lazy file discovery and 
statistics then use the same resolved snapshot, and a nonexistent snapshot ID 
fails during planning. File discovery remains deferred in lazy mode.
   
   Preserve `LazyFileScanTaskProvider::snapshot_id()` semantics: `None` still 
means the current snapshot was requested. Add `snapshot()` to expose the 
resolved snapshot, returning `None` only for a table with no current snapshot.
   
   Validation:
   - Confirmed the lazy-planning regression test fails against the original 
implementation.
   - Added missing-snapshot checks for eager and lazy planning, plus 
integration coverage matching current/historical snapshot selection to 
statistics and returned rows.
   - `cargo test --workspace --locked`
   - `cargo clippy --workspace --locked --all-targets -- -D warnings`
   - `cargo fmt --all -- --check`
   - `git diff --check`
   
   Developed with AI assistance.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to