goldmedal commented on code in PR #12490:
URL: https://github.com/apache/datafusion/pull/12490#discussion_r1768930022
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -1811,6 +1811,211 @@ mod test {
Ok(())
}
+ #[test]
+ fn tes_case_when_list() -> Result<()> {
+ let inner_field = Arc::new(Field::new("item", DataType::Int64, true));
+ let schema = Arc::new(DFSchema::from_unqualified_fields(
+ vec![
+ Field::new(
+ "large_list",
+ DataType::LargeList(Arc::clone(&inner_field)),
+ true,
+ ),
+ Field::new(
+ "fixed_list",
+ DataType::FixedSizeList(Arc::clone(&inner_field), 3),
+ true,
+ ),
+ Field::new("list", DataType::List(inner_field), true),
+ ]
+ .into(),
+ std::collections::HashMap::new(),
+ )?);
+
+ macro_rules! test_case_expression {
+ ($expr:expr, $when_then:expr, $case_when_type:expr,
$then_else_type:expr, $schema:expr) => {
+ let case = Case {
+ expr: Some(Box::new(col($expr))),
+ when_then_expr: $when_then,
+ else_expr: None,
+ };
+
+ let case_when_common_type = $case_when_type;
+ let then_else_common_type = $then_else_type;
+ let expected = cast_helper(
+ case.clone(),
+ &case_when_common_type,
+ &then_else_common_type,
+ &$schema,
+ );
+
+ let actual = coerce_case_expression(case, &$schema)?;
+ assert_eq!(expected, actual);
+ };
+ }
Review Comment:
Sounds great. I tried to simplify them in a8ea6cf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
