comphead commented on code in PR #12617: URL: https://github.com/apache/datafusion/pull/12617#discussion_r1775792354
########## datafusion/physical-plan/src/aggregates/group_values/column_wise.rs: ########## @@ -36,7 +36,7 @@ use datafusion_physical_expr::binary_map::OutputType; use hashbrown::raw::RawTable; -/// Compare GroupValue Rows column by column +/// A [`GroupValues`] that stores multiple columns of group values. Review Comment: I'm not very familiar with it and thus the question, what is group values? is it group keys, or exact values attached for specific key? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
