akurmustafa commented on code in PR #12654:
URL: https://github.com/apache/datafusion/pull/12654#discussion_r1778906297
##########
datafusion/common/src/utils/mod.rs:
##########
@@ -291,10 +291,7 @@ pub(crate) fn parse_identifiers(s: &str) ->
Result<Vec<Ident>> {
}
/// Construct a new [`Vec`] of [`ArrayRef`] from the rows of the `arrays` at
the `indices`.
-pub fn get_arrayref_at_indices(
- arrays: &[ArrayRef],
- indices: &PrimitiveArray<UInt32Type>,
-) -> Result<Vec<ArrayRef>> {
+pub fn take_arrays(arrays: &[ArrayRef], indices: &dyn Array) ->
Result<Vec<ArrayRef>> {
Review Comment:
Exactly, this util is just to abstract away same outer iteration for the
`compute::take`. If community thinks, this is beneficial, we can move this to
`arrow-rs`. I think, this pattern is common enough to move it to `arrow-rs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
