alamb commented on code in PR #13336: URL: https://github.com/apache/datafusion/pull/13336#discussion_r1840317120
########## datafusion/sqllogictest/test_files/string/dictionary_utf8.slt: ########## @@ -64,6 +64,22 @@ _ (empty) false false false false NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL NULL +# TODO: move it back to `string_query.slt.part` after fixing the issue +# see issue https://github.com/apache/datafusion/pull/13221 Review Comment: https://github.com/apache/datafusion/pull/13221 is now fixed, so I think we can move this test to `string_query.slt` that being said, this seems like it is an improvement to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
