findepi commented on code in PR #13576:
URL: https://github.com/apache/datafusion/pull/13576#discussion_r1880116392
##########
datafusion/common/src/config.rs:
##########
@@ -212,11 +219,12 @@ config_namespace! {
pub enable_ident_normalization: bool, default = true
/// When set to true, SQL parser will normalize options value (convert
value to lowercase)
- pub enable_options_value_normalization: bool, default = true
+ pub enable_options_value_normalization: bool, default = false
Review Comment:
I don't think that solution is good enough for the long-term.
I understand a global config was introduced to avoid changing behavior for
everyone, but that clearly doesn't work when different parts of the system need
different behavior. For example S3 component needs case-sensitivity whereas
some other component, breaks when lowercasing is turned off.
The global config toggle solved the problem only for some use-cases and only
for people knowing about the toggle. This PR aims to solve the problem the
better way (IMO).
I would prefer we continue with the approach proposed here and later
deprecate the global toggle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
