viirya commented on code in PR #1050:
URL: https://github.com/apache/datafusion-comet/pull/1050#discussion_r1888051357
##########
common/src/main/java/org/apache/comet/parquet/ColumnReader.java:
##########
@@ -172,28 +172,6 @@ public void close() {
/** Returns a decoded {@link CometDecodedVector Comet vector}. */
public CometDecodedVector loadVector() {
- // Only re-use Comet vector iff:
Review Comment:
I don't know how much performance gain we got from reusing `CometVector`
here. Note that it doesn't skip loading data into buffer in native side. It
just reuses JVM `CometVector`.
This reuse conflicts safety check. Because in CometColumnarToRow, we close
columnar vectors to remove buffer reference in JVM after accessing them.
`loadVector` is called after that to load next columnar vector (i.e.,
`CometVector`). As it is closed, we cannot reuse it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
