viirya commented on code in PR #1050:
URL: https://github.com/apache/datafusion-comet/pull/1050#discussion_r1889073914
##########
common/src/main/java/org/apache/comet/parquet/ColumnReader.java:
##########
@@ -172,28 +172,6 @@ public void close() {
/** Returns a decoded {@link CometDecodedVector Comet vector}. */
public CometDecodedVector loadVector() {
- // Only re-use Comet vector iff:
Review Comment:
This needs to be removed. As I explained above early, without removing it,
we cannot close columnar vectors in `CometColumnarToRow` and it is required to
pass safety check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
