andygrove commented on code in PR #1253: URL: https://github.com/apache/datafusion-comet/pull/1253#discussion_r1909258219
########## spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala: ########## @@ -89,6 +89,24 @@ class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper { } } + // based on Spark's SQLWindowFunctionSuite test of the same name + test("window function: partition and order expressions") { + for (shuffleMode <- Seq("auto", "native", "jvm")) { Review Comment: Not directly, but due to an existing issue in Comet, we fall back to Spark for this query if shuffle mode is auto or native, so we only see the issue when specifying jvm shuffle. See https://github.com/apache/datafusion-comet/issues/1248 for more info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org