andygrove commented on code in PR #1262: URL: https://github.com/apache/datafusion-comet/pull/1262#discussion_r1911777608
########## spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala: ########## @@ -974,7 +974,8 @@ class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper { } } - test("distinct") { + // TODO enable once https://github.com/apache/datafusion-comet/issues/1267 is implemented Review Comment: I understand what is happening now. Spark optimizes some simple cases like `SELECT a, COUNT(DISTINCT b) ...` to first perform an aggregate to just get the distinct values, so by the time we perform the `COUNT` there are only distinct values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org