alamb opened a new pull request, #14155: URL: https://github.com/apache/datafusion/pull/14155
## Which issue does this PR close? - Part of https://github.com/apache/datafusion/issues/13748 ## Rationale for this change In order to optimize the ordering calculations, we may need to change how the structures are represented internally. Since all the inner fields are `pub` making such changes requires too many changes over the codebase ## What changes are included in this PR? 1. Make `LexOrdering::inner` non pub, 2. add comments, 3. update usages <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? Yes, by existing CI <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 5. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? This is a deliberate API change that forces all `LexOrdering` object to be created via constructor rather than directly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
