iffyio commented on code in PR #1677:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1677#discussion_r1925582444
##########
src/dialect/mod.rs:
##########
@@ -304,6 +304,11 @@ pub trait Dialect: Debug + Any {
false
}
+ /// Returns true if the dialect supports numbers containing underscores
+ fn supports_underscore_separator(&self) -> bool {
Review Comment:
```suggestion
fn supports_numeric_literal_underscores(&self) -> bool {
```
something like this? thinking `underscore_operator` wouldn't be descriptive
on its own
##########
src/tokenizer.rs:
##########
@@ -2223,6 +2227,22 @@ mod tests {
compare(expected, tokens);
}
+ #[test]
+ fn tokenize_clickhouse_underscore_separator() {
Review Comment:
```suggestion
fn tokenize_numeric_literal_underscore() {
```
##########
src/dialect/mod.rs:
##########
@@ -304,6 +304,11 @@ pub trait Dialect: Debug + Any {
false
}
+ /// Returns true if the dialect supports numbers containing underscores
Review Comment:
```suggestion
/// Returns true if the dialect supports numbers containing underscores.
e.g. `10_000_000`
```
Thinking an example would clarify even further what it implies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
