andygrove commented on code in PR #1331:
URL: https://github.com/apache/datafusion-comet/pull/1331#discussion_r1927422973
##########
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##########
@@ -19,18 +19,23 @@
package org.apache.comet.serde
-import org.apache.spark.sql.catalyst.expressions.{ArrayRemove, Expression}
+import org.apache.spark.sql.catalyst.expressions.{ArrayRemove, Attribute,
Expression}
import org.apache.spark.sql.types.{ArrayType, DataType, DataTypes,
DecimalType, StructType}
import org.apache.comet.CometSparkSessionExtensions.withInfo
+import org.apache.comet.serde.QueryPlanSerde.createBinaryExpr
import org.apache.comet.shims.CometExprShim
-trait CometExpression {
- def checkSupport(expr: Expression): Boolean
+trait CometExpressionSerde {
Review Comment:
Yes, currently, there is only one implementation, which is why it is here at
the moment, but this can move to a common class. Perhaps I should just move
this into QueryPlanSerde source file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
