shehabgamin commented on code in PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#discussion_r1928600951
##########
datafusion/functions/src/string/ascii.rs:
##########
@@ -61,7 +64,15 @@ impl Default for AsciiFunc {
impl AsciiFunc {
pub fn new() -> Self {
Self {
- signature: Signature::string(1, Volatility::Immutable),
+ signature: Signature::one_of(
+ vec![
+ TypeSignature::String(1),
+ TypeSignature::Coercible(vec![TypeSignatureClass::Native(
Review Comment:
Although it was not my intention to apply this pattern on single arg
functions. I'll get that fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
