buraksenn commented on code in PR #14279:
URL: https://github.com/apache/datafusion/pull/14279#discussion_r1929594954
##########
datafusion/physical-expr/src/analysis.rs:
##########
@@ -179,7 +179,17 @@ pub fn analyze(
expr.as_any()
.downcast_ref::<Column>()
.filter(|expr_column| bound.column.eq(*expr_column))
- .map(|_| (*i, bound.interval.clone()))
+ .map(|_| {
+ (
+ *i,
+ match bound.interval.clone() {
Review Comment:
My intention was to panic on developer error in which analysis function
should not receive a `None` interval. However, as you've said since function
returns Result internal_error probably has the same idea so changed to that.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
