adriangb commented on code in PR #14362:
URL: https://github.com/apache/datafusion/pull/14362#discussion_r1934364024
##########
datafusion/expr/src/utils.rs:
##########
@@ -736,11 +802,18 @@ pub fn exprlist_to_fields<'a>(
.into_iter()
.map(|c| c.flat_name())
.collect();
+ excluded.extend(
+ get_system_columns(wildcard_schema, None)?
+ .into_iter()
+ .map(|c| c.flat_name()),
+ );
Ok(wildcard_schema
.fields_with_qualified(qualifier)
.into_iter()
.filter_map(|field| {
- let flat_name = format!("{}.{}", qualifier,
field.name());
+ let flat_name =
+ Column::new(Some(qualifier.clone()),
field.name())
+ .flat_name();
Review Comment:
Small nit of the existing code. I'd rather re-use the logic for creating
flat names at a trivial cost just to avoid having arbitrary string formatting
going on here.
##########
datafusion/expr/src/utils.rs:
##########
@@ -706,6 +770,7 @@ pub fn exprlist_to_fields<'a>(
// Look for exact match in plan's output schema
let wildcard_schema = find_base_plan(plan).schema();
let input_schema = plan.schema();
+ let exprs = exprs.into_iter().collect::<Vec<_>>();
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
