comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1939820038
##########
Makefile:
##########
@@ -95,7 +98,7 @@ release-linux: clean
cd native && RUSTFLAGS="-Ctarget-cpu=native
-Ctarget-feature=-prefer-256-bit" cargo build --release
./mvnw install -Prelease -DskipTests $(PROFILES)
release:
- cd native && RUSTFLAGS="-Ctarget-cpu=native" cargo build --release
+ cd native && RUSTFLAGS="$(RUSTFLAGS) -Ctarget-cpu=native" &&
RUSTFLAGS=$$RUSTFLAGS cargo build --release $(FEATURES_ARG)
Review Comment:
Makefile syntax lightly different from bash from what I learned.
so in order to access environment variable created on fly it is needed to
access it with $$.
It gets created on fly to concatenate release specific RUSTFLAGS with ones
that user can set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
