Lordworms commented on PR #14409: URL: https://github.com/apache/datafusion/pull/14409#issuecomment-2635087583
> struct_coercion Sure, I can do that > Hi @Lordworms -- thank you very much for this PR and for working on the issue > > While reviewing this PR I noticed a few other tests that I think we should add (are you willing to do so?) > > 1. Adding a test for `coalesece(column1, column2)` and `coalesce(column2, column3) which is similar to union and case > 2. Adding a test for comparison `column1 = column` and `column2 = column3` which is also similar > > Then in terms of code, As this PR demonstrates, there are at least three places that do versions of this struct comparision that need to be changed as they have different versions of code that does about the same thing by coercing structs. > > I think @jayzhan211's suggestion on https://github.com/apache/datafusion/pull/14384/files#r1937492704 > > > Yes, I think type union resolution is the correct on for CASE > > Means that we should be aiming towards consolidating / using the same rules. > > Maybe you could move the checks into `struct_coercion` and then update any other coercion that needed to coerce structs to use that one? Ok, I'll add that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
