rkrishn7 commented on code in PR #14472:
URL: https://github.com/apache/datafusion/pull/14472#discussion_r1943660946
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -296,12 +298,14 @@ impl LogicalPlanBuilder {
field_types.push(common_type.unwrap_or(DataType::Null));
}
- Self::infer_inner(values, &field_types, &schema)
+ let field_nullabilities = (0..n_cols).map(|_|
true).collect::<Vec<_>>();
+ Self::infer_inner(values, &field_types, &field_nullabilities, &schema)
}
fn infer_inner(
mut values: Vec<Vec<Expr>>,
field_types: &[DataType],
+ field_nullabilities: &[bool],
Review Comment:
Yes, good call out!
We clone the data type to construct the field, so I just created a small
container which encapsulates the naming logic as well. Think it cleans things
up a bit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
