geoffreyclaude commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r1962048387
##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -5568,6 +5573,16 @@ SELECT STRING_AGG(x,',') FROM strings WHERE g > 100
----
NULL
+query T
+SELECT STRING_AGG(DISTINCT x,',') FROM strings WHERE g > 100
Review Comment:
nit: missing space between the `x` and `','`.
##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -5547,6 +5547,11 @@ SELECT STRING_AGG(column1, '|') FROM (values (''),
(null), (''));
----
|
+query T
+SELECT STRING_AGG(DISTINCT column1, '|') FROM (values (''), (null), (''));
Review Comment:
Same comment as in the [`array_agg`
PR](https://github.com/apache/datafusion/pull/14413), can you add one or two
tests triggering errors? Just to validate that invalid delimiters for instance
are correctly detected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
