konjac commented on PR #1015: URL: https://github.com/apache/datafusion-python/pull/1015#issuecomment-2676912860
> This looks good. It took me a while to parse through the logic of the `get_batches`. I think it's worth adding some documentation within the file to explain why we are doing this so that future maintainers can understand the necessity of doing it this way. > > Thank you for the PR! Thank you for the reviewing! A new iteration is pushed to add code comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
