vmingchen opened a new pull request, #1195:
URL: https://github.com/apache/datafusion-ballista/pull/1195

   Partial fix to https://github.com/apache/datafusion-ballista/issues/1194
   
   The `.tbl` files generated by `tpch-gen.sh` has an additional trailing 
column that need to be special-treated by `get_tbl_tpch_table_schema`.
   
   After this the tests are running, but with some failures:
   
   ```shell
   $ cd <BALLISTA_HOME>/benchmarks
   $ TPCH_DATA=data cargo test
   ...
   failures:
       tests::q1
       tests::q10
       tests::q11
       tests::q14
       tests::q15
       tests::q17
       tests::q18
       tests::q19
       tests::q2
       tests::q20
       tests::q21
       tests::q22
       tests::q3
       tests::q5
       tests::q6
       tests::q7
       tests::q8
       tests::q9
   ...
   ```
   
   After this PR, some tests pass but still quite some are failing:
   
   ```
   running 44 tests
   07:50:07 [160/4254]
   test tests::q15 ... FAILED
   test tests::q13 ... FAILED
   test tests::q1 ... FAILED
   test tests::q18 ... FAILED
   test tests::q10 ... FAILED
   test tests::q11 ... FAILED
   test tests::q12 ... FAILED
   test tests::q17 ... FAILED
   test tests::q14 ... FAILED
   test tests::q19 ... FAILED
   test tests::q4 ... FAILED
   test tests::q20 ... FAILED
   test tests::q3 ... FAILED
   test tests::q22 ... FAILED
   test tests::q6 ... FAILED
   test tests::q21 ... FAILED
   test tests::q2 ... FAILED
   test tests::run_q1 ... ok
   test tests::run_q10 ... ok
   test tests::run_2 ... ok
   test tests::run_q15 ... ignored
   test tests::run_q11 ... ok
   test tests::run_q12 ... ok
   test tests::run_q13 ... ok
   test tests::q5 ... FAILED
   test tests::q7 ... FAILED
   test tests::run_q14 ... ok
   test tests::q9 ... FAILED
   test tests::run_q18 ... ok
   test tests::run_q17 ... ok
   test tests::run_q16 ... ok
   test tests::run_q19 ... ok
   test tests::run_q20 ... ok
   test tests::run_q6 ... ok
   test tests::run_q22 ... ok
   test tests::run_q21 ... ok
   test tests::run_q3 ... ok
   test tests::run_q4 ... ok
   test tests::q8 ... FAILED
   test tests::q16 ... FAILED
   test tests::run_q5 ... ok
   test tests::run_q9 ... ok
   test tests::run_q7 ... ok
   test tests::run_q8 ... ok
   ```
   
   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to