Re: [PR] feat: Upgrade to DataFusion 46.0.0-rc2 [datafusion-comet]

[via GitHub]

andygrove commented on code in PR #1423:
URL: https://github.com/apache/datafusion-comet/pull/1423#discussion_r1981857954


##########
native/spark-expr/src/agg_funcs/stddev.rs:
##########
@@ -56,11 +57,11 @@ impl Stddev {
         Self {
             name: name.into(),
             signature: Signature::coercible(
-                vec![
+                vec![Coercion::new_exact(

Review Comment:
   This use of `Coercion::new_exact` means that we only accept the specific 
type (`Float64`) and will not perform any coercion.
   
   From DataFusion docs:
   
   ```
   /// There are two variants:
   ///
   /// * `Exact` - Only accepts arguments that exactly match the desired type
   /// * `Implicit` - Accepts the desired type and can coerce from specified 
source types
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org