andygrove commented on code in PR #1423:
URL: https://github.com/apache/datafusion-comet/pull/1423#discussion_r1981864217
##########
native/core/src/parquet/mod.rs:
##########
@@ -687,16 +675,30 @@ pub unsafe extern "system" fn
Java_org_apache_comet_parquet_Native_initRecordBat
SparkParquetOptions::new(EvalMode::Legacy,
session_timezone.as_str(), false);
spark_parquet_options.allow_cast_unsigned_ints = true;
- let builder2 = ParquetExecBuilder::new(file_scan_config)
- .with_table_parquet_options(table_parquet_options)
-
.with_schema_adapter_factory(Arc::new(SparkSchemaAdapterFactory::new(
- spark_parquet_options,
- )));
+ let mut table_parquet_options = TableParquetOptions::new();
+ // TODO: Maybe these are configs?
+ table_parquet_options.global.pushdown_filters = true;
+ table_parquet_options.global.reorder_filters = true;
+
+ let parquet_source =
ParquetSource::new(table_parquet_options).with_schema_adapter_factory(
+ Arc::new(SparkSchemaAdapterFactory::new(spark_parquet_options)),
+ );
+ //.with_schema(Arc::new(required_schema_arrow));
Review Comment:
I have removed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
