berkaysynnada commented on code in PR #14995:
URL: https://github.com/apache/datafusion/pull/14995#discussion_r1982218157


##########
datafusion/physical-plan/src/stream.rs:
##########
@@ -241,8 +241,17 @@ impl RecordBatchReceiverStreamBuilder {
         self.inner.spawn(task)
     }
 
-    /// Spawn a blocking task that will be aborted if this builder (or the 
stream
-    /// built from it) are dropped
+    /// Spawns a blocking task that attempts to send `RecordBatch` data to 
this stream.

Review Comment:
   Current usages can be limited with this use case, but if we look at the 
signature, this util is not limited with that case only. Perhaps we can 
generalize this more?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to