wiedld commented on code in PR #15074:
URL: https://github.com/apache/datafusion/pull/15074#discussion_r1985718541
##########
datafusion/core/tests/physical_optimizer/enforce_distribution.rs:
##########
@@ -1733,12 +1760,9 @@ fn smj_join_key_ordering() -> Result<()> {
" RepartitionExec: partitioning=RoundRobinBatch(10),
input_partitions=1",
" DataSourceExec: file_groups={1 group: [[x]]},
projection=[a, b, c, d, e], file_type=parquet",
];
- assert_optimized!(
- expected,
- join.clone(),
- &TestConfig::new(DoFirst::Distribution).with_prefer_existing_sort()
- );
+ test_config.run(expected, join.clone(), DISTRIB_DISTRIB_SORT.into())?;
+ // Test: result IS DIFFERENT, if EnforceSorting is run first:
Review Comment:
Highlighting the dependency of run ordering in the existing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
