alamb commented on code in PR #15104:
URL: https://github.com/apache/datafusion/pull/15104#discussion_r1986315228
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -5673,3 +5673,43 @@ async fn test_fill_null_all_columns() -> Result<()> {
assert_batches_sorted_eq!(expected, &results);
Ok(())
}
+
+#[tokio::test]
+async fn test_sql_support_sql_to_view_types() -> Result<()> {
Review Comment:
Instead of adding rust based tests, could you please make these sqllogictest
based instead? sqllogictest is easier to maintain and run
The instructions are here
https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest
Perhaps as a new test in
https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/ddl.slt
##########
datafusion/common/src/config.rs:
##########
@@ -252,6 +252,11 @@ config_namespace! {
/// string length and thus DataFusion can not enforce such limits.
pub support_varchar_with_length: bool, default = true
+ /// If true, permit `VARCHAR` default convert to `Utf8View` in the
logical plan.
+ /// If false, `VARCHAR` will be converted to `Utf8` in the logical
plan.
+ /// Default is false.
+ pub support_varchar_to_view_types: bool, default = false
Review Comment:
I recommend naming this slightly differently to make it clearer what it is
doing
```suggestion
/// If true, `VARCHAR` is mapped to `Utf8View` during SQL planning.
/// If false, `VARCHAR` is mappped to `Utf8` during SQL planning.
/// Default is false.
pub default_varchar_views: bool, default = false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
