2010YOUY01 commented on code in PR #15137: URL: https://github.com/apache/datafusion/pull/15137#discussion_r1988371514
########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -179,19 +185,31 @@ physical_plan 06)└─────────────┬─────────────┘ 07)┌─────────────┴─────────────┐ 08)│ RepartitionExec │ -09)└─────────────┬─────────────┘ -10)┌─────────────┴─────────────┐ -11)│ AggregateExec │ -12)└─────────────┬─────────────┘ -13)┌─────────────┴─────────────┐ -14)│ RepartitionExec │ +09)│ -------------------- │ +10)│ output_partition_count: │ +11)│ 4 │ +12)│ │ +13)│ partitioning_scheme: │ +14)│ Hash([string_col@0], 4) │ Review Comment: Perhaps we don't need this `, 4)` if we have already displayed output partition. ########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -155,13 +155,19 @@ physical_plan 09)└─────────────┬─────────────┘ 10)┌─────────────┴─────────────┐ 11)│ RepartitionExec │ -12)└─────────────┬─────────────┘ -13)┌─────────────┴─────────────┐ -14)│ DataSourceExec │ -15)│ -------------------- │ -16)│ files: 1 │ -17)│ format: csv │ -18)└───────────────────────────┘ +12)│ -------------------- │ +13)│ output_partition_count: │ +14)│ 1 │ +15)│ │ +16)│ partitioning_scheme: │ +17)│ RoundRobinBatch(4) │ Review Comment: What is this 4? 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
