Standing-Man commented on code in PR #15137: URL: https://github.com/apache/datafusion/pull/15137#discussion_r1990387199
########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -155,13 +155,19 @@ physical_plan 09)└─────────────┬─────────────┘ 10)┌─────────────┴─────────────┐ 11)│ RepartitionExec │ -12)└─────────────┬─────────────┘ -13)┌─────────────┴─────────────┐ -14)│ DataSourceExec │ -15)│ -------------------- │ -16)│ files: 1 │ -17)│ format: csv │ -18)└───────────────────────────┘ +12)│ -------------------- │ +13)│ output_partition_count: │ +14)│ 1 │ +15)│ │ +16)│ partitioning_scheme: │ +17)│ RoundRobinBatch(4) │ Review Comment: In `RoundRobinBatch(usize)`, it indicates how many partitions the round-robin algorithm should produce. In `Hash(Vec<Arc<dyn PhysicalExpr>>, usize)`, it specifies the number of partitions that the hash-based algorithm will create. The number of output partitions seems a bit redundant, and I haven’t found the number of input partitions. :sweat_smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
