mvzink commented on code in PR #1762:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1762#discussion_r1987884388
##########
src/parser/mod.rs:
##########
@@ -8002,6 +8002,11 @@ impl<'a> Parser<'a> {
&& dialect_of!(self is MySqlDialect | GenericDialect)
{
AlterTableOperation::DropPrimaryKey
+ } else if self.parse_keywords(&[Keyword::FOREIGN, Keyword::KEY])
+ && dialect_of!(self is MySqlDialect | GenericDialect)
Review Comment:
This matches the branch just above for `DROP PRIMARY KEY`: I didn't add a
new dialect flag because I'm not sure what exactly it should be called, what
should go in there, or whether it's worth the verbosity. Should it also apply
to the `ALTER TABLE DROP PRIMARY KEY` syntax, for example? Feedback is welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
