EmilyMatt commented on code in PR #1514:
URL: https://github.com/apache/datafusion-comet/pull/1514#discussion_r1993064941
##########
native/Cargo.toml:
##########
@@ -35,22 +35,10 @@ rust-version = "1.85"
[workspace.dependencies]
arrow = { version = "54.2.0", features = ["prettyprint", "ffi", "chrono-tz"] }
-arrow-array = { version = "54.2.0" }
-arrow-buffer = { version = "54.2.0" }
-arrow-data = { version = "54.2.0" }
-arrow-schema = { version = "54.2.0" }
async-trait = { version = "0.1" }
bytes = { version = "1.10.0" }
parquet = { version = "54.2.0", default-features = false, features =
["experimental"] }
-datafusion = { version = "46.0.0", default-features = false, features =
["unicode_expressions", "crypto_expressions"] }
-datafusion-common = { version = "46.0.0", default-features = false }
-datafusion-datasource = { version = "46.0.0", default-features = false }
-datafusion-functions = { version = "46.0.0", default-features = false,
features = ["crypto_expressions"] }
-datafusion-functions-nested = { version = "46.0.0", default-features = false }
-datafusion-expr = { version = "46.0.0", default-features = false }
-datafusion-expr-common = { version = "46.0.0", default-features = false }
-datafusion-execution = { version = "46.0.0", default-features = false }
-datafusion-physical-expr = { version = "46.0.0", default-features = false }
+datafusion = { version = "46.0.0", default-features = false, features =
["unicode_expressions", "crypto_expressions", "nested_expressions", "parquet"] }
Review Comment:
no it just means that `datafusion` does not enable its default-features, but
the way the crates are structures, no dependencies have any default features
except of the core one, so this specifying it for the root crate is enough.
Same goes for the arrow crates
(which is something I really appreciate about that ecosystem tbh)
##########
native/Cargo.toml:
##########
@@ -35,22 +35,10 @@ rust-version = "1.85"
[workspace.dependencies]
arrow = { version = "54.2.0", features = ["prettyprint", "ffi", "chrono-tz"] }
-arrow-array = { version = "54.2.0" }
-arrow-buffer = { version = "54.2.0" }
-arrow-data = { version = "54.2.0" }
-arrow-schema = { version = "54.2.0" }
async-trait = { version = "0.1" }
bytes = { version = "1.10.0" }
parquet = { version = "54.2.0", default-features = false, features =
["experimental"] }
-datafusion = { version = "46.0.0", default-features = false, features =
["unicode_expressions", "crypto_expressions"] }
-datafusion-common = { version = "46.0.0", default-features = false }
-datafusion-datasource = { version = "46.0.0", default-features = false }
-datafusion-functions = { version = "46.0.0", default-features = false,
features = ["crypto_expressions"] }
-datafusion-functions-nested = { version = "46.0.0", default-features = false }
-datafusion-expr = { version = "46.0.0", default-features = false }
-datafusion-expr-common = { version = "46.0.0", default-features = false }
-datafusion-execution = { version = "46.0.0", default-features = false }
-datafusion-physical-expr = { version = "46.0.0", default-features = false }
+datafusion = { version = "46.0.0", default-features = false, features =
["unicode_expressions", "crypto_expressions", "nested_expressions", "parquet"] }
Review Comment:
no it just means that `datafusion` does not enable its default-features, but
the way the crates are structures, no dependenciy has any default features
except of the core one, so this specifying it for the root crate is enough.
Same goes for the arrow crates
(which is something I really appreciate about that ecosystem tbh)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
