zhuqi-lucas commented on code in PR #15200:
URL: https://github.com/apache/datafusion/pull/15200#discussion_r1993723658
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -126,6 +126,28 @@ where
}
}
+#[derive(Debug)]
+struct StringViewHLLAccumulator<T>
+where
+ T: OffsetSizeTrait,
+{
+ hll: HyperLogLog<String>,
+ phantom_data: PhantomData<T>,
+}
+
+impl<T> StringViewHLLAccumulator<T>
+where
+ T: OffsetSizeTrait,
+{
+ /// new approx_distinct accumulator
Review Comment:
Good point @Weijun-H , addressed in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
